lura icon indicating copy to clipboard operation
lura copied to clipboard

adds HEAD method to gin router

Open vrnvu opened this issue 4 years ago • 1 comments

PR addresses #436 and adds HEAD for the gin router.

vrnvu avatar Nov 05 '21 11:11 vrnvu

adding proper support for HEAD requests is not an easy task. HEAD is a 'safe' method but it has some particularities, such as sending a content-length header with the value it would return to a GET request but without the actual body. unfortunately, these particularities do not fit very well on our model. I'll throw here some of the questions I think we should answer before coding a single line:

1- how to deal with composed request? 2- how to deal with changes in the response encoding? 3- how to deal with the response manipulation (mapping, filtering and so on)? 4- how to deal with incomplete responses (when composing)?

finally, the response to a HEAD request shouldn't include a body and your code doesn't deal with that

thanks

kpacha avatar Nov 08 '21 16:11 kpacha

closing due inactivity

kpacha avatar Nov 24 '22 14:11 kpacha

This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link.

github-actions[bot] avatar Feb 23 '23 00:02 github-actions[bot]