Matteo Luppi

Results 36 comments of Matteo Luppi

> > but it's not straightforward since here we simply propagate the value and call `updateOptions` > > Yeah, I think that's what we need to change! How about we...

I probably found a solution :) is it okay now @mhils ? if it so, I'll update the test since now it fails

@mhils I can have a look if possible! the problem here is just the string "No such script" that shouldn't be there when the input is empty?

makes sense yes, okay I'll have a look! Yes I've noticed :)

Could I have a look at this?

> > Could I have a look at this? > > There is already a PR #5996 Would be great if you can check it out locally and leave feedback...

I'm opening this PR now but I'm facing a problem with this test `should handle error when toggling regular`, so the pipeline is failing 😅

okay thanks :) I'm fixing the tests right now

it should be fine now, I'll merge it then :)

@mhils maybe you've missed it :) let me know if I should add/fix something! Thx 😃