psl icon indicating copy to clipboard operation
psl copied to clipboard

punycode is deprecated in Node v21

Open AnWeber opened this issue 1 year ago • 7 comments

Using punycode is deprecated in Node v21. See documentation https://nodejs.org/api/punycode.html. Maybe try replacing with NPM Package punycode

punycode is used here: https://github.com/lupomontero/psl/blob/797ccb41136a75b5737ea1e4d2bdcaad0dac02de/index.js#L5

Fix:

  1. npm i punycode
  2. change from require("punycode") to require("punycode/")

https://github.com/AnWeber/httpyac/issues/577

AnWeber avatar Nov 01 '23 19:11 AnWeber

There is already a pull request from 2022 fixing this issue.

#298

AnWeber avatar Nov 03 '23 20:11 AnWeber

@lupomontero

quinton-ashley avatar Dec 29 '23 15:12 quinton-ashley

https://github.com/lupomontero/psl/commit/3ddec00372501a4657d28fbd87e6fd59db12a897 See this commit and it may suggest that new version be released soon.

ryuujo1573 avatar Feb 05 '24 05:02 ryuujo1573

This is already fixed. We are just waiting for a new release. Patience is a virtue.

jm42 avatar Mar 04 '24 08:03 jm42

@jm42

This is already fixed. We are just waiting for a new release. Patience is a virtue.

Can you clarify why you suggest just waiting? Are you a maintainer and you are planning a release?

It's 2 months ago since @lupomontero added a series of commits into the master branch including the fix https://github.com/lupomontero/psl/commit/3ddec00372501a4657d28fbd87e6fd59db12a897 for this issue.

If you are not a maintainer, then perhaps @lupomontero could say if/when a new release is planned?

MikeMcC399 avatar Mar 04 '24 09:03 MikeMcC399

Thank you for maintaining this package! I understand that it is a lot of work. It would be appreciated with a release that includes thix fix.

skagedal avatar May 02 '24 07:05 skagedal