psl icon indicating copy to clipboard operation
psl copied to clipboard

chore(deps): Replaces deprecated Punycode provided by Node with punycode.js

Open lupomontero opened this issue 2 years ago • 1 comments

Node's Punycode module has been deprecated for years as pointed out by @Macil in #296.

This PR replaces the deprecated module with mathiasbynens/punycode.js as suggested.

lupomontero avatar Jul 04 '22 14:07 lupomontero

any idea when this can be merged? Would be nice to not have the deprecation warning anymore after this is in :)

gboer avatar Sep 07 '22 08:09 gboer

When will this be merged?

brycefranzen avatar Feb 06 '23 23:02 brycefranzen

@lupomontero punycode is runtime deprecated in the upcoming Node v21, printing a noisy deprecation warning. Do you think you can land this and release a patch? 🙂

SimenB avatar Sep 09 '23 09:09 SimenB

Node v21 is released, and it's complaining about deprecated punycode module. Can this be merged?

dmitryplatonov avatar Nov 16 '23 16:11 dmitryplatonov

@lupomontero

Are you planning to release a new version now?

v1.9.0 is still the latest release.

MikeMcC399 avatar Jan 08 '24 12:01 MikeMcC399

@lupomontero any chance you could tag this new version? we are still getting the old one, so merging the PR didn't help to solve the problem completely.

thank you!

ravanscafi avatar Feb 21 '24 22:02 ravanscafi