Nick Thomas

Results 33 comments of Nick Thomas

I've just experienced this issue while porting GitLab's spec suite from the truncation strategy to the deletion strategy: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16516#note_55605767 If there's still interest in a PR to fix this upstream,...

I've hit this too. Poking the code, it looks like `X-Forwarded-For` is taken into account only for the rate-limiting, and not for the logging or other uses that may come...

https://github.com/mjl-/mox/pull/381