apple-signin-unity icon indicating copy to clipboard operation
apple-signin-unity copied to clipboard

Support for VisionOS

Open snowyao opened this issue 1 year ago • 9 comments

Any plan for VisionOS support?

snowyao avatar Dec 04 '23 08:12 snowyao

Bump. I'd also like to see this.

There's a couple of lines in the code where only iOS, tvOS and macOS are being checked for. I guess if these lines were modified to include visionOS as well, it might work out-of-the-box.

derwaldgeist avatar Jan 05 '24 18:01 derwaldgeist

Ok. I tried to patch the library in my fork:

https://github.com/marblear/apple-signin-unity/tree/visionos

Turns out that modifying the OS-specific conditional compilations was not enough. It seems as if the PolySpatial app delegate has to be patched as well. I get a runtime error that it does not accept a certain selector.

derwaldgeist avatar Jan 05 '24 20:01 derwaldgeist

My 2019 Macbook does not support the VisionOS simulator...

Screenshot 2024-01-21 at 12 34 41

lupidan avatar Jan 21 '24 11:01 lupidan

Yep. I actually had to get an M3 macBook just to do that. Which is silly, but was the only way.

derwaldgeist avatar Jan 21 '24 12:01 derwaldgeist

Ok. I tried to patch the library in my fork:

https://github.com/marblear/apple-signin-unity/tree/visionos

Turns out that modifying the OS-specific conditional compilations was not enough. It seems as if the PolySpatial app delegate has to be patched as well. I get a runtime error that it does not accept a certain selector.

Are you suggesting that Unity needs to make some kind of change? Do you have any further details (remember what the specific error was / have a stack trace?)

delphinius81 avatar Mar 20 '24 00:03 delphinius81

Same request, marked

ChuanlongChen avatar Mar 20 '24 08:03 ChuanlongChen

Hey guys, I've successfully make it works in VisionOS, but seems I can't create PR for this repo, I modify it in my own fork. Here is the PR: https://github.com/ChuanlongChen/apple-signin-unity/pull/1 You can consider integrate my modifications to this repo too.

FYI @lupidan @snowyao @derwaldgeist @delphinius81

ChuanlongChen avatar Mar 22 '24 07:03 ChuanlongChen

Update: I'm able to create PR for this repo https://github.com/lupidan/apple-signin-unity/pull/198

ChuanlongChen avatar Mar 22 '24 07:03 ChuanlongChen

@lupidan it would be great if you could take time to review my pr

ChuanlongChen avatar Apr 13 '24 02:04 ChuanlongChen