apple-signin-unity icon indicating copy to clipboard operation
apple-signin-unity copied to clipboard

Added Async/Await support via TaskCompletionSource wrappers.

Open Juiix opened this issue 2 years ago • 2 comments

Juiix avatar Jun 18 '22 04:06 Juiix

Toxic

Koushik1029 avatar Jun 19 '22 11:06 Koushik1029

Toxic

Informative

Juiix avatar Jun 19 '22 15:06 Juiix

it'd be better if there would be UniTasks

Basically, that's what I do everytime)

image

UmarBhatPlaystrom avatar Apr 26 '23 08:04 UmarBhatPlaystrom

Thanks a lot for your time and the proposed Pull Request. 👏

While I see the value for this particular PR, I think this would better work with some kind of extensions that wraps around the already available code based on callbacks.

Also, I have been trying to avoid "modern C# stuff" such as the Task class, so this code can work even in old Unity versions.

Basically, I believe each game should decide and implement their own Task support around the current functionality.

I'll consider adding Task support in some other version.

lupidan avatar Sep 30 '23 10:09 lupidan