Don't process default methods at all

Open jtulach opened this issue 5 years ago • 1 comments

Hi. I am trying to upgrade Bck2Brwsr VM usage of Retrolamda from 2.1.0 to 2.5.7. I am facing problems. Bck2Brwsr doesn't need help with default methods, only with lambdas. Looks like that version 2.5.7 isn't really ready for that.

This change, together with 3a5bb2a change seem to do the trick. Can you please review them and accept or suggest better way to do what is necessary?

One surprising issue is that I have to call analyzer.analyse myself as it is not called when defaultMethodsEnabled is false.

Then I needed to somehow disable creation of the companion class. The protected method which allows me to return existing class name seems to do the trick.

My changes just outline what is necessary. I am sure you can come up with better fixes.

Btw. it maybe hard to test with defaultMethodsEnabled being off - if you are interested, I could prepare some testcase using Bck2Brwsr AOT compilation & execution. It might make upgrading to new retrolambda version less painful in the future.

Oct 18 '20 12:10 jtulach

Is there any chance this PR gets in and a new release is crafted anytime soon? Or shall I fork my own copy of Retrolamda into Bck2Brwsr VM?

Jul 09 '21 05:07 jtulach