nanny icon indicating copy to clipboard operation
nanny copied to clipboard

Maintainability score dropped to C

Open PhilipSchmid opened this issue 3 years ago • 1 comments

Hi @lunemec and @thomae

With the recent changes, the maintainability score from Code Climate dropped from an A to a C: https://codeclimate.com/github/lunemec/nanny/issues

Do you guys think it's possible and worth to refactor the code to eliminate the Code Climate findings?

Thanks & regards, Philip

PhilipSchmid avatar Feb 26 '21 12:02 PhilipSchmid

@PhilipSchmid good catch! Yeah, we should refactor some parts. But the report shows warnings for structs implementing a interface. Which is kinda incorrect.

It might help to have each Notifier in its own separate package, implementing the interface, that way it might be better in the report as a package implementing certain interface.

But yeah, definitely its worth to refactor.

lunemec avatar Feb 26 '21 12:02 lunemec

Stale. Not interested anymore.

PhilipSchmid avatar Jun 21 '23 17:06 PhilipSchmid