lune icon indicating copy to clipboard operation
lune copied to clipboard

Update `lune setup` to respect Luau LSP v1.36

Open CompeyDev opened this issue 1 year ago • 1 comments

In Luau LSP v1.36, the luau-lsp.require.directoryAliases configuration was deprecated in favor of using aliases defined in the .luaurc file. Lune should be updated to respect this new configuration method.

However, transitioning to .luaurc poses a challenge since users who are still on earlier versions of Luau LSP will lose autocomplete functionality if we implement this change. A potential solutions would involve us determining the version of Luau LSP that is currently in use, or introducing a flag which allows users to explicitly specify if they want editor settings instead of a .luaurc change.

CompeyDev avatar Dec 07 '24 07:12 CompeyDev

However, transitioning to .luaurc poses a challenge since users who are still on earlier versions of Luau LSP will lose autocomplete functionality if we implement this change. A potential solutions would involve us determining the version of Luau LSP that is currently in use, or introducing a flag which allows users to explicitly specify if they want editor settings instead of a .luaurc change.

This seems like a non-issue to me, we should be fine to just make the change to use .luaurc without adding additional complexity to the command. People using Luau LSP most likely use an editor that auto-updates extensions (VSCode), so if they're on an older version it's because they have already messed with their editor config to disable auto update.

filiptibell avatar Dec 18 '24 22:12 filiptibell

So I made this script for newer luau-lsp

jiwonz avatar May 08 '25 04:05 jiwonz

Fixed in https://github.com/lune-org/lune/commit/1a8dd789745c778113ac576e30d9f4bd6dfd740f

filiptibell avatar Jun 13 '25 10:06 filiptibell