lune icon indicating copy to clipboard operation
lune copied to clipboard

Include zstd compression & decompression in serde

Open CompeyDev opened this issue 1 year ago • 6 comments
trafficstars

Closes #202.

CompeyDev avatar May 28 '24 07:05 CompeyDev

Looks good so far! Just the tests failing, does the zstd cli need some args changed maybe?

I've tried most permutations of the arguments that I can pass to the CLI - async-compression's best mode corresponds on ZSTD's MAX_CLEVEL, which is 22 (I've read the source of both the crate and zstd to confirm this).

CompeyDev avatar Jun 03 '24 04:06 CompeyDev

Did you figure out what could be going on here? Not really sure myself but I also haven't looked too deeply into it.

filiptibell avatar Jul 06 '24 20:07 filiptibell

Did you figure out what could be going on here?

Unfortunately no :( Others in the lune channel could not figure it out either.

CompeyDev avatar Jul 07 '24 08:07 CompeyDev

According to the zstd CLI tool (downloaded from the zstd repo) the best compression level is 19. Are we sure that 22 is the max it uses?

Dekkonot avatar Oct 26 '24 23:10 Dekkonot

According to the zstd CLI tool (downloaded from the zstd repo) the best compression level is 19. Are we sure that 22 is the max it uses?

between 1 and 19; << In normal mode They provide '--ultra' extra option (Enable levels beyond 19, up to 22; requires more memory.) Steps 20 and above work a little differently and are slower

qwreey avatar Oct 28 '24 02:10 qwreey

any updates on this?

ActualMasterOogway avatar Jan 10 '25 16:01 ActualMasterOogway

Superseded by #339

filiptibell avatar Aug 31 '25 10:08 filiptibell