Jonas Lundberg

Results 82 comments of Jonas Lundberg

Need more context, closing this for now. Please re-open if still a problem and/or docs should be adjusted.

Lets break it down ... Currently the `json=` pattern only supports the `EQUAL` *lookup*, and is using json dump (string) to compare the left and right side. This means that...

> Thanks for the explanation. Can I help somehow? The `JSON` pattern needs to be adjusted to not hash/dump when the pattern has a *path* .. I think that would...

I like the idea, but maybe it could be implemented in current `EnvironWrapper` as a setting, i.e. `EnvironWrapper(require_defaults=True)`. That way the api could stay the same, and one could either...

Good points, totally agree. Only itching part left to solve IMO is import/instantiating of the "safe" version. I'm thinking, if you know you want the safe raising version, then you...

> Could it be worth a breaking change and entirely discarding the current behavior? We could introduce a deprecation warning in place of raising in a minor version. Had the...

This is not a *bug*, and instead by design to align with how pythons existing unittest `Mock` behave. Though, I can kind-of agree with you that it would be a...

Yes, the docs/readme needs to be updated and clearer. Related to #44

> @lundberg Is this relevant or should I close this? I guess it doesn't hurt, let's keep it 😉