lunar icon indicating copy to clipboard operation
lunar copied to clipboard

Maintain Brands in table instead of distinct from Products table

Open wychoong opened this issue 2 years ago • 4 comments

Discussed in https://github.com/getcandy/getcandy/discussions/448

Originally posted by wychoong August 3, 2022 the current Brands list for a product is getting distinct brand from Products table. suggest to use a Brands table for:

  • maintainability
  • scaleable (instead of distinct a huge product table)

any suggestions for how to implementing this as it will be a BC

wychoong avatar Aug 04 '22 10:08 wychoong

Further thoughts from Discord discussions included...

  • Potentially have multiple brands per product (would need to have a primary brand set)
  • Ability to add a brand logo
  • Maybe even allow for custom attributes

glennjacobs avatar Aug 05 '22 09:08 glennjacobs

@glennjacobs Will aim to have this completed by the end of the week. @alecritson is it ok to start this off from your data-tables branch or should I wait until you have merged into develop?

Another feature I would suggest here will be to show the products relation table so once you click to view each brand you will be able to manage products for the brand. Also the brands list should display a counter for products.

I won't be implementing multiple brands per products. I believe product features or tags will be more than enough to handle these type of searches.

adam-code-labx avatar Aug 07 '22 10:08 adam-code-labx

@adam-code-labx Sorry for the delay, I think at this point the data-tables branch would be fine for you to branch from if you need to.

alecritson avatar Aug 09 '22 12:08 alecritson

Ok thanks will get started on this.

adam-code-labx avatar Aug 09 '22 14:08 adam-code-labx

This should be sorted on 0.1.0-rc.1

alecritson avatar Sep 26 '22 14:09 alecritson