lunar icon indicating copy to clipboard operation
lunar copied to clipboard

Unify naming of `inclTax` and `exclTax`

Open adevade opened this issue 1 month ago • 2 comments

Currently most methods and properties use variants of incTax and exTax, while one place (CartLine::$unitPriceInclTax) uses inclTax.

This could be unified to inclTax and exclTax in v2, which makes both variants equal in character length.

Discussed briefly in Discord 2025-11-20: https://discord.com/channels/497326121441034240/705350345857040464/1441115249792258160

adevade avatar Nov 20 '25 17:11 adevade

Would it be worth adding the new methods/properties and @deprecating the existing so that people can be better prepared 🤔

alecritson avatar Dec 11 '25 15:12 alecritson

Sounds like a very good idea! 👍

adevade avatar Dec 11 '25 16:12 adevade