lunar icon indicating copy to clipboard operation
lunar copied to clipboard

Bump dependencies in `monorepo-builder.php`

Open adevade opened this issue 1 year ago • 1 comments

This PR updates the dependencies listed in monorepo-builder.php, and runs the monorepo-builder merge command.

Question: What is the benefit of having these dev dependencies defined in monorepo-builder.php, instead of just in composer.json?

adevade avatar Jul 02 '24 13:07 adevade

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 2:33pm

vercel[bot] avatar Jul 02 '24 13:07 vercel[bot]

Thanks. Sometimes this seems to get missed as it's a manual process. I'm not quite sure on the best approach to avoid it happening again.

Question: What is the benefit of having these dev dependencies defined in monorepo-builder.php, instead of just in composer.json?

The individual packages don't have tests inside them, so therefore don't have the dev dependencies.

glennjacobs avatar Jul 04 '24 13:07 glennjacobs

The individual packages don't have tests inside them, so therefore don't have the dev dependencies.

If they're defined in the root composer.json dev-deps, would they be stripped out after a monorepo-builder merge command, if not defined through the php file?

adevade avatar Jul 04 '24 13:07 adevade