lunar icon indicating copy to clipboard operation
lunar copied to clipboard
verified publisher icon lunarphp

fix bad merge

Open wychoong opened this issue 1 year ago • 3 comments

Please describe your Pull Request as best as possible, explaining what it provides and why it is of value, referencing any related Issues.

Try to include the following in your Pull Request, where applicable...

  • Documentation updates
  • Automated tests

wychoong avatar May 26 '24 15:05 wychoong

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 11:28am

vercel[bot] avatar May 26 '24 15:05 vercel[bot]

@alecritson @wychoong is this still needed? I can see it's draft, but at the same time Alec approved it.

glennjacobs avatar Jun 11 '24 11:06 glennjacobs

Not sure why it’s changed to draft

wychoong avatar Jun 11 '24 12:06 wychoong

@glennjacobs I took a fresh look on it, this should be the proper way. updated my findings in the first comment.

It also makes me think should all the usage of AsCollection cast in the models to be reviewed and changed to AsArrayObject

wychoong avatar Jul 31 '24 15:07 wychoong