lunar icon indicating copy to clipboard operation
lunar copied to clipboard

Published 20 hours ago • verified publisher icon lunarphp

Some texts don't have translations

Open rinodrummer opened this issue 1 year ago • 3 comments

  • Lunar version: 0.4
  • Laravel Version: 10.15.0
  • PHP Version: 8.1

While testing for Italian translation me and @sebhd1 noticed that most of the texts in packages/admin/resources/views/partials/forms/discount.blade.php are not using __() so there are no related entries in translation files.

rinodrummer avatar Jul 21 '23 16:07 rinodrummer

While going on testing, we also discovered that the translations are missing on the specified file: lunar/packages/admin/src/Menu/SettingsMenu.php.

sebhd1 avatar Jul 21 '23 16:07 sebhd1

You may as well update them when doing your translation PR.

glennjacobs avatar Jul 21 '23 17:07 glennjacobs

You may as well update them when doing your translation PR.

Ok! Perfect!

We were worried about the conventions relative to the keys in the translation files, but we'll try our best to match the standards!

We will keep writing here where we spot issues just to keep track and then close the issue along with the PR we are going to open.

rinodrummer avatar Jul 21 '23 18:07 rinodrummer