luasocket icon indicating copy to clipboard operation
luasocket copied to clipboard

Remove deprecated URL params parsing

Open alerque opened this issue 2 years ago • 3 comments

See discussion begun in in #418

alerque avatar Nov 09 '23 11:11 alerque

Is this what you had in mind @catwell?

Should this be considered a breaking change? That might affect what our next version number is.

Besides stopping to document this as a feature we should probably document the removal too.

alerque avatar Nov 09 '23 11:11 alerque

@alerque Yes, I had no idea it would be so impacting. It might be considered a breaking change but I would be surprised if people relied on this behavior. Tools typically implement the newer behavior e.g.:

$ trurl -g "{path"} "ftp://root:[email protected]/pub/virus.exe;type=i"
/pub/virus.exe;type=i

And by the way trurl which is a good reference considers empty paths to be /.

$ trurl -g "{path"} "https://foo.bar?foo=bar"
/

catwell avatar Nov 09 '23 12:11 catwell

Also just for reference, the RFC that standardized params was 1995 and the RFC that obsoleted it with no mention of params was 2005.

I'm not too worried about dropping it without much ado, but we should still be careful. This library is used a lot of places and I want to keep the friction of updating to a minimum.

alerque avatar Nov 09 '23 12:11 alerque