Does not compile in Windows in Unicode (WCHAR) mode

[rpatters1]

It is easy enough to fix by appending "A" to the affected functions:

• CreateFileA
• GetFinalPathNameByHandleA
• CreateHardLinkA
• CreateSymbolicLinkA
• GetFileAttributesExA

However, it really depends on what the goal of the repo is. A more appropriate approach might be to convert all the relevant strings to WCHAR and call the W versions. This would require changing the inputs from ANSI to UTF8.

[cuavas]

See discussion on #57 – changing the lfs API to use UTF-8 would make it incompatible with built-in Lua functionality. For example you wouldn’t be able to pass a file name from an lfs directory listing to io.open.

[rpatters1]

If you change the Window API calls to explicitly use the A functions, then the project will build in either MultiByte or Unicode modes but continue to function the same. (That is, it will continue to be compatible with io.open.)

Windows itself now has a UTF8 option for ANSI. I would hope it will gradually move everyone in that direction. That will allow all 8-bit char functions (including Lua's) to run with utf8.