luna
luna copied to clipboard
Get WalkingQueue under test
Thank you for contributing to the Luna project!
Proposed changes
The goal here is to create tests for WalkingQueue. This will allow me to refactor the class without losing any of the object's behaviours.
Once WalkingQueue is under test, I'll be able to address #186
Pull Request type
What types of changes does your code introduce to Luna?
Put an x
in the boxes that apply
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
- [x] I have read the CONTRIBUTING doc
- [x] Unit tests pass locally, after applying my changes
- [x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
- [x] I have added necessary documentation
- [x] Any dependent changes have been merged and published in downstream modules
Further comments
The removal of the 'final' keyword from LunaContext, WalkingQueue, and PlayerSettings were to mock/create null objects. By doing so, WalkingQueue can be tested without any existing network connections and/or configuration files.