luna icon indicating copy to clipboard operation
luna copied to clipboard

Published 20 hours ago • verified publisher icon luna-rs

refactor(root): move logging settings/configuration into a single package

Open notjuanortiz opened this issue 4 years ago • 4 comments

This PR includes a few minor, but related, changes.

  • Moves LoggingSettings, and LoggingConfigurationFactory into a single package io.luna.logging
  • Separates file reading logic from logging settings/configuration (see Luna.class), This was done in case someone wants to change the file type being read (currently .toml).
  • Includes unit test for TomlLoggingSettingFileReader to ensure the code works as intended.

Contributes to #215 .

notjuanortiz avatar Mar 23 '20 16:03 notjuanortiz

Hey @notjuanortiz,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 879c0450-6d33-11ea-8920-b3945d724fa9

TravisBuddy avatar Mar 23 '20 18:03 TravisBuddy

This issue has been marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

stale[bot] avatar May 24 '20 15:05 stale[bot]

This issue has been closed because it has not had any recent activity. Feel free to re-open this issue or create another one if the problem isn't resolved.

stale[bot] avatar May 31 '20 15:05 stale[bot]

https://github.com/luna-rs/luna/pull/220/commits/826565c32d53a5729ebc264285bb4a3cf1de3cd0

By creating an abstraction I've decoupled reading the logging settings from a file from actually starting the server. I also made support for reading settings from other file types much easier to implement. I'm not sure I understand what the motivation to revert this change is.

notjuanortiz avatar Jan 21 '21 21:01 notjuanortiz