lumen icon indicating copy to clipboard operation
lumen copied to clipboard

feat: allow non-english languages as tag

Open zaaakher opened this issue 1 year ago • 3 comments
trafficstars

closes #354

Tags can now be created with non-english languages.

Supported languages:

  • Arabic
  • French
  • German
  • Italian
  • Spanish
  • Portuguese
  • Dutch
  • Scandinavian languages (e.g., Swedish, Danish, Norwegian, Icelandic, Faroese)
  • Polish
  • Czech
  • Slovak
  • Hungarian
  • Latvian
  • Lithuanian
  • Russian
  • Ukrainian
  • Bulgarian
  • Serbian
  • Armenian
  • Hebrew
  • Persian (Farsi)
  • Urdu
  • Hindi
  • Marathi
  • Nepali
  • Sanskrit
  • Chinese (Simplified and Traditional)
  • Japanese (Kanji)
  • Korean (Hanja and Hangul)

Special thanks to ChatGPT for helping me with this one 😄

zaaakher avatar Jul 20 '24 21:07 zaaakher

Deploy Preview for lumen-notes ready!

Name Link
Latest commit 21276a3d4e4c4e35d635784ff138c44a2acbbd5f
Latest deploy log https://app.netlify.com/sites/lumen-notes/deploys/66a58bc8a427750008eca1e3
Deploy Preview https://deploy-preview-382--lumen-notes.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 57
Accessibility: 81
Best Practices: 100
SEO: 75
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 20 '24 21:07 netlify[bot]

Deploy Preview for lumen-storybook ready!

Name Link
Latest commit 21276a3d4e4c4e35d635784ff138c44a2acbbd5f
Latest deploy log https://app.netlify.com/sites/lumen-storybook/deploys/66a58bc8c8dcc10009af6d8b
Deploy Preview https://deploy-preview-382--lumen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 20 '24 21:07 netlify[bot]

Could you add some non-english tests to src/remark-plugins/tag.test.ts?

Done 👍 , I added 19 tests. although 4 tests kept failing and I couldn't figure out why. So I commented them out. Now it's 15 additional tests added.

zaaakher avatar Jul 24 '24 19:07 zaaakher