docs icon indicating copy to clipboard operation
docs copied to clipboard

Update Grant Permission Guide

Open fhildeb opened this issue 1 year ago • 2 comments

Features

  • Updates outdated Grant Permissions Guide of the Expert -> Key Manager Section
  • Uses dynamic array encoding to add controllers
  • Simplifies descriptions and headings
  • Fixes code and adds ethers.js support
  • Adds reference to lukso-playground

Playground

  • https://github.com/lukso-network/lukso-playground/pull/57

fhildeb avatar Apr 12 '24 16:04 fhildeb

Deployed with Cloudflare Pages :cloud: :rocket: :ok:

github-actions[bot] avatar Apr 12 '24 16:04 github-actions[bot]

Thanks for the feedback, @CJ42. As you can see from the removed WIP banner, this guide was quite outdated. Descriptions were duplicated, code snippets did not work, and the playground was not in sync.

Therefore, this PR combined these two tickets to get everything up to date:

  • https://app.clickup.com/t/2645698/DEV-10581 (rework code + descriptions)
  • https://app.clickup.com/t/2645698/DEV-10091 (update erc725.js encoding)

Applied the suggestions. LGTM

fhildeb avatar Apr 16 '24 09:04 fhildeb

We will do it again from scratch. Closing.

Hugoo avatar Jun 11 '24 09:06 Hugoo