keywind icon indicating copy to clipboard operation
keywind copied to clipboard

feat: email theme

Open paulwer opened this issue 2 years ago • 25 comments

closes https://github.com/lukin/keywind/issues/47 references https://github.com/lukin/keywind/issues/6

Hey folks, ive managed a mailwind integration.

From my pov it may not be perfect, but it works as intended (for me). any thoughts on this?

I've created this theme based on the mailwind front-website example.

emails should be tested for visibility on the most used e-mail clients (help wanted):

  • [x] Apple
  • [X] GMAIL
  • [x] Outlook
  • [x] Thunderbird
  • [x] Yahoo Mail
  • [x] WEB.de
  • [x] Outlook.com

paulwer avatar Sep 25 '23 06:09 paulwer

did someone want to check/help and give feedback for a client? @CHE1RON @lukin

paulwer avatar Sep 25 '23 13:09 paulwer

display on gmail Unbekannt

known issues:

  • fallback to background color, because background div is not displayed properly on gmail (position: fixed ignored) => update 29.9.14:24: fixed, also works with background image now

paulwer avatar Sep 26 '23 06:09 paulwer

Looks promising! Never heard of Mailwind before, thanks!

CHE1RON avatar Sep 26 '23 06:09 CHE1RON

display on web.de Unbenannt known issues:

  • fallback to background color -> reason: not checked => update 29.9.14:24: fixed, also works with background image now

paulwer avatar Sep 27 '23 06:09 paulwer

@CHE1RON @lukin any other providers needed / wished / to be checked?

paulwer avatar Sep 27 '23 06:09 paulwer

I guess Gmail as de-facto standard is all that needs to be checked really 😅

CHE1RON avatar Sep 27 '23 10:09 CHE1RON

Don't get me wrong, privately I don't have a Gmail account - but nearly everyone I know has one ..

CHE1RON avatar Sep 27 '23 10:09 CHE1RON

outlook still doesnt looks great, i guess exspecialy for companies, this would be great to optimize at least -_-

paulwer avatar Sep 27 '23 11:09 paulwer

As far as my scarce experience with Outlook goes, fixing it is out of scope for keywind 😂

CHE1RON avatar Sep 27 '23 12:09 CHE1RON

i think checking on apple should be also a prio: 1689235958-most-used-email-clients-worldwide

(wold usage of mail clients from 2023 according to: Website

paulwer avatar Sep 27 '23 15:09 paulwer

Feel free to send emails to folkers [at] codefy [dot] de and I'll post screenshots 😉

CHE1RON avatar Sep 28 '23 07:09 CHE1RON

@CHE1RON you should have recieved an email yesterday :)

paulwer avatar Sep 29 '23 07:09 paulwer

Screenshot 2023-09-29 at 10 03 23

looks good 👍

CHE1RON avatar Sep 29 '23 08:09 CHE1RON

yahoo Unbenannt

known issues:

  • no background at all => I guess we can ignore this

paulwer avatar Sep 29 '23 09:09 paulwer

as mentioned outlook still looks not good, i will try to come up with some changes to change this: Unbenannt

paulwer avatar Sep 29 '23 09:09 paulwer

@paulwer I mean it says right there in your screenshot: if it looks shitty, please view it in your browser 😂

CHE1RON avatar Sep 29 '23 09:09 CHE1RON

@CHE1RON I've sended you another e-mail, please check the formatting, outlook looks now better and the other platforms are still optical the same: Unbenannt

i changed the usage of div's to the table syntax for old email clients. i will commit, if this looks also good on apple :)

paulwer avatar Sep 29 '23 11:09 paulwer

outlook.com works like a charm Unbenannt

background images are now present on all platforms i tested. <3 (only outlook destop does not display it xD)

paulwer avatar Sep 29 '23 12:09 paulwer

thunderbird also works great <3 Unbenannt

android gmail and outlook tested as well and worked great. gmail does display it as dark mode variant, but its readable and approved from my pov.

paulwer avatar Sep 29 '23 12:09 paulwer

@lukin any test files needed for this PR?

paulwer avatar Sep 29 '23 17:09 paulwer

macOS Mail:

image

CHE1RON avatar Sep 30 '23 18:09 CHE1RON

@lukin this pr is ready to be merged

paulwer avatar Oct 01 '23 04:10 paulwer

within this PR, I used the mailwind logo as default logo. should we replace it with a keycloak logo to match a more "default" - alike look or remove the logo by default, to be fit with plain installation and maybe display just the realm name, if nothing is defined... I could also imagine a customization behavior within theme.properties, like mentioned in: #59

any opinions on that? @lukin @CHE1RON

paulwer avatar Oct 02 '23 08:10 paulwer

I see no apparent reason why keywind should propagate Mailwind by using its logo by default 🤔

No logo imho 👍

CHE1RON avatar Oct 02 '23 17:10 CHE1RON

@CHE1RON is right, the logo should be optional. Therefore i will push a commit with the mentioned themeLogoUrl as property of the theme shortly. if no url is provided the realmName as heading is used accordingly.

@lukin PR is ready again :)

paulwer avatar Oct 05 '23 05:10 paulwer

closed in favor for: https://github.com/lukin/keywind/pull/96

paulwer avatar Jun 19 '24 09:06 paulwer

Hey folks, How do I get the email template? The latest keywind branch still doesnt show any email templates at all?

LeftoversTodayAppAdmin avatar Aug 22 '24 02:08 LeftoversTodayAppAdmin

this was closed in favor for #96. all changes here are present in the other pr

paulwer avatar Aug 22 '24 03:08 paulwer