Luke Yeh

Results 8 comments of Luke Yeh

Here's a list of a search for `Result` I'll go through them checking if we should return errors instead ``` ./crates/scheduler/src/call/timer.rs 105:) -> Result { ``` This should return `Result`...

> Prelude functions should panic on errors that the user could have prevented (e.g. out of bound index). Hey just to make sure I understand this point. By panicking do...

> Sorry, I probably used a misleading title in #463. This PR is not fixing the core idea of #463 but just introducing an unused private type, which is not...

Addressed comments and applied changes to equivalent areas that you didn't leave comments PTAL

went through the new pass of comments with the new pattern and other various nits

My only working solution is to store the closure, wrapped in a box in a struct. Is there a better way to do this? ```rust struct Data, } impl Future...

Thanks for the pointers and being patient with me! Not sure why I was so fixated on sticking the `waker.wake()` in the closure and using that as the data!

@ia0 could you assign this issue to me thank you!