Luke Sonnet

Results 74 comments of Luke Sonnet

Great! Thanks! We're still gonna wait to push this out until `gt` is on CRAN.

I've been able to recreate this in some contexts, but I can't figure out what the pattern is.

This looks like a bug in NSE of the `fixed_effects` within the data cleaning function. No idea why this is happening as so I'll have to investigate. For now unfortunately...

Thanks @gerasy1987 , I'll look in to this!

So the idea is to have glance report joint specification f tests when we are glancing a `lh_robust` object?

But these are different tests? I'm not sure how these are testing the same thing. I think our help is wrong. We can still add this feature to glance, but...

Argh we should have removed this example before 0.20.0. They _aren't_ the same.

I'm happy to remove the constraint in `difference_in_means()` because it is just kicking to `lm_robust()` in the clustered case anyways. I don't believe I have access to it today, but...

Any advice here? I don't think we can very easily accommodate this and believe we should explicitly fail to support this with a message, while just returning the usual `lm_robust()`...

Anyone have any feelings re: error? I think that's also reasonable. I'll implement it as such later today/tomorrow if no other feedback.