xunit-viewer icon indicating copy to clipboard operation
xunit-viewer copied to clipboard

Published 20 hours ago • verified publisher icon lukejpreston

filter using react router

Open lukejpreston opened this issue 5 years ago • 5 comments

lukejpreston avatar Nov 29 '19 09:11 lukejpreston

@lukejpreston could you please open a WIP MR for this feature? I have a couple suggessions for your current code, which would be quite near this feature

zeburek avatar Feb 19 '20 18:02 zeburek

I almost have something working, it is only a couple of lines long. What sort of suggestions did you have?

lukejpreston avatar Feb 20 '20 08:02 lukejpreston

Use React hooks + Context provider instead of dispatcher mecanism

It will simplify the code and will make it clear

zeburek avatar Feb 20 '20 08:02 zeburek

I don't think this issue should solve refactoring problems, but I love the enthusiasm! I have a bunch of cleaning jobs I would like to do which include looking at what you have suggested here

lukejpreston avatar Feb 21 '20 07:02 lukejpreston

Hello :slightly_smiling_face: Any news on this feature ?

tbourrelovh avatar Jul 08 '21 07:07 tbourrelovh

This is doable now https://github.com/lukejpreston/xunit-viewer/releases/tag/v10.0.0 It only filters by test status for now, once the cli filtering has been fixed the two can be aligned

lukejpreston avatar Jun 23 '23 09:06 lukejpreston