servor
servor copied to clipboard
Trailing slash on SPA route
Hey.
I'm using Servor to serve an SPA with create-react-app
The problem is - whenever my SPA route ends with a slash I have 404.
For example, let's say I'm serving my app from https://myapp.com
, and I have a react route /hello-world
.
This URL works fine https://myapp.com/hello-world
But this one gives me 404 https://myapp.com/hello-world/
Thanks for the report and sorry for the late reply I have been busy with some other projects. I'm not sure why servor doesn't strip trailing slashes.. would have to go check the code but I don't imagine it would be a massive pain to implement.
I've been meaning to address all the PRs on this repo for a while. If you find a fix feel free to make a pull request and I will address it with the others.
Thanks for the report and sorry for the late reply I have been busy with some other projects. I'm not sure why servor doesn't strip trailing slashes.. would have to go check the code but I don't imagine it would be a massive pain to implement.
I've been meaning to address all the PRs on this repo for a while. If you find a fix feel free to make a pull request and I will address it with the others.
Hi, I was about to start the fix on my own but then found this https://github.com/lukejacksonn/servor/pull/82 Wdyt?