CShell icon indicating copy to clipboard operation
CShell copied to clipboard

Published 20 hours ago • verified publisher icon lukebuehler

StyleCop fixes for CShell.Hosting

Open theelderwand opened this issue 9 years ago • 4 comments

https://github.com/lukebuehler/CShell/issues/80

theelderwand avatar Nov 03 '15 17:11 theelderwand

Thanks for this PR, I merged it locally, but also quickly realized that we need to be careful how we configure the settings.

I do not agree with all stylecop defaults and want to disable a few. I'm trying to set it up properly though based on your initial template.

lukebuehler avatar Nov 05 '15 16:11 lukebuehler

I already disabled a few where i felt like for example the documentation XML etc. Please feel free to edit it and a template that we can work with. As mentioned in the issue https://github.com/lukebuehler/CShell/issues/80 i wanted to start off somewhere. Once you push a commit i'll start fixing the other projects and we can integrate it with build. Also, I am quite curious about the roadmap, would it be possible for you to share one ?

theelderwand avatar Nov 05 '15 17:11 theelderwand

Yep, let me think some more about how to introduce stylecop gracefully. I think we should incrementally enable rules.

Re roadmap, here: https://github.com/lukebuehler/CShell/wiki/Roadmap

lukebuehler avatar Nov 05 '15 21:11 lukebuehler

Alright that works well too. Once a minimal set is ready, I'll start fixing the remaining projects.

theelderwand avatar Nov 09 '15 17:11 theelderwand