Luke Brandon Farrell comments

Results 62 comments of


Luke Brandon Farrell

Picker returns empty array of assets when iPhone 13 Pro raw (.dng) photo is selected [🐛]

@wmatyjanomtek Also, since I don't have a 12 or 13, could you get me a video of taking a DNG picture then picking it from library? So I can get...

Picker returns empty array of assets when iPhone 13 Pro raw (.dng) photo is selected [🐛]

@wmatyjanomtek Hopefully, we are running it on our production application and waiting for a review from @Johan-dutoit

Picker returns empty array of assets when iPhone 13 Pro raw (.dng) photo is selected [🐛]

Sounds good @Johan-dutoit, we should have some data soon! :)

Add `cookedFileName`, to give `fileName` with extension when possible

I'll give this a review @chrisbobbe !

fix(android): Add filename extension to `fileName` for videos from library

@Johan-dutoit this is technically a breaking change no? Maybe we want to add a new property i.e. `"extension"` and include it in there instead.

fix(android): Add filename extension to `fileName` for videos from library

@chrisbobbe What is the use case here, why do you need the file name extension in your app?

fix(android): Add filename extension to `fileName` for videos from library

@chrisbobbe are you open to expanding on this to return `extension` as a separate key?

fix(android): Add filename extension to `fileName` for videos from library

@chrisbobbe Since we already have MIME type returned we could do this all on the JavaScript layer? We just add `fileName` + the end of the extension `mime?.split("/")[1]` and return...

fix(android): Add filename extension to `fileName` for videos from library

@chrisbobbe Gotcha, starting to follow now! I think this sounds good, @Johan-dutoit what do you think of this?

[🐛] Returns JPG MIME type(Incorrect) in case user select TTF type images.

This is because on iOS images are converted to either JPEG or PNG, hence the type is correct.