Luke Bemish

Results 164 comments of Luke Bemish

Irregardless of that, I am still against including spotless in the MDK due to the requirement it sometimes enforces on using the same java version to run gradle as to...

Additionally, I do not believe that enforcing consistent formatting is a good idea. The configuration included here is _highly_ opinionated, and there is no reason to enforce most of those...

> EDIT: seems like gradle only allows switching between "any" and "openJ9" :/ You're thinking `JvmImplementation`, which can be `J9` or `VENDOR_SPECIFIC`. Specifying the vendor uses the line in the...

It allows specifying "openj9" or "whatever" for _implementation_, yes, but it also allows specifying _vendor_ - so just specify Microsoft as the vendor and you'll get their openjdk - the...

This gets iffy _fast_. For instance, how do you handle something like a `ConfiguredFeature` that has a `Feature` as its type? What about the number of other worldgen things that...

> Note that we could also request that Fabric change their format, since at the end of the day we are accommodating for Fabric here. (Which I do not like...

Putting this here so it doesn't get lost in the depths of discord: I think this PR needs better documentation of examples of places it would actually be useful. Currently,...

Correct me if I'm wrong, but the parameters substitution approach Techni4n mentions requires stuff on the code end, does it not? Thus, it is not viable for translations where the...

The scope of what mods want to do and need to do is far larger than the scope of what vanilla does or needs to do. Your assessment that vanilla...

This isn't hypothetical. For a very real use of something like the plural system, see the fluid unit PR which ran into pain here. That sort of formatting varies by...