tsoa
tsoa copied to clipboard
Nullable regression
All Submissions:
- [x] Have you followed the guidelines in our Contributing document?
- [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
- [x] Have you written unit tests?
- [x] Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
- [ ] This PR is associated with an existing issue?
Closing issues
Put closes #XXXX
(where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.
If this is a new feature submission:
- [ ] Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?
Potential Problems With The Approach
Test plan
@WoH before I go further with this, could you quickly take a look and confirm whether the test I added is indeed the desired behavior? The test is currently failing (but it used to work in 5.1.1), and I'd like to try and contribute a fix once I get your confirmation
Yeah. Nullable and x-nullable, but the prop should be required. That's correct
Thanks for taking a look into that
@WoH I was able to track down that https://github.com/lukeautry/tsoa/pull/1498 was the change which broke this (the test passes on the commit prior), but I haven't been able to figure out the right way to fix it yet.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days