tsoa icon indicating copy to clipboard operation
tsoa copied to clipboard

add ability to include custom swagger extensions in config

Open gwprice115 opened this issue 1 year ago • 1 comments

All Submissions:

More than happy to write tests and stuff once I get confirmation this is the right approach

  • [ ] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [ ] Have you written unit tests?
  • [ ] Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • [x] This PR is associated with an existing issue?

Closing issues closes #1532 Put closes #XXXX (where XXXX is the issue number) in your comment to auto-close the issue that your PR fixes.

If this is a new feature submission:

  • [ ] Has the issue had a maintainer respond to the issue and clarify that the feature is something that aligns with the goals and philosophy of the project?

Potential Problems With The Approach

Test plan

gwprice115 avatar Jan 08 '24 22:01 gwprice115

Would love to see this go in will make our lives much easier

TristanSpeakEasy avatar Jan 11 '24 17:01 TristanSpeakEasy

This would probably require us to also be able to use a .tsoa.js as config file instead of the tsoa.json, if you don't call generateSwagger directly, but use the cli. (And also live in the spec config) Also, it should be bw-compat if not provided.

WoH avatar Feb 08 '24 08:02 WoH

This would probably require us to also be able to use a .tsoa.js as config file instead of the tsoa.json, if you don't call generateSwagger directly, but use the cli. (And also live in the spec config) Also, it should be bw-compat if not provided.

gotcha makes sense--would you accept it if it was a static reference similar to how auth is specified?

gwprice115 avatar Feb 29 '24 18:02 gwprice115

Yes

WoH avatar Feb 29 '24 19:02 WoH

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] avatar Mar 31 '24 00:03 github-actions[bot]