tsoa icon indicating copy to clipboard operation
tsoa copied to clipboard

Unused imports and parameters in generated hapi routes file

Open leonlaser opened this issue 1 year ago • 2 comments

Hello 👋 I am a developor for project PIA and we are currently integrating tsoa into our hapi based services.

We are compiling with noUnusedLocals and noUnusedParameters set to true and stumbled upon the hapi route generator template having both, unused imports and unused parameters.

Sorting

  • I'm submitting a ...

    • [x] bug report
    • [ ] feature request
    • [ ] support request
  • I confirm that I

    • [x] used the search to make sure that a similar issue hasn't already been submit

Expected Behavior

The generated routes file for hapi should not trigger errors for unused imports and parameters, when the compilerOptions noUnusedLocals and noUnusedParameters are set to true.

Current Behavior

Errors are thrown when noUnusedLocals and noUnusedParameters are set to true.

Possible Solution

Our solution is to prepend the generated file with // @ts-nocheck. As the hapi.hbs template already has /* tslint:disable */ and /* eslint-disable */ modifiers, // @ts-nocheck could be added, too.

Steps to Reproduce

Setup tsoa.json with:

{
  "routes": {
    "middleware": "hapi",
    "routesDir": "src",
  }
}

Setup tsconfig.json with

{
  "compilerOptions": {
    "noUnusedLocals": true,
    "noUnusedParameters": true,
  }
}

Context (Environment)

Version of the library: 5.1.1 Version of NodeJS: 20.3.0

  • Confirm you were using yarn not npm: [ ]

leonlaser avatar Dec 29 '23 16:12 leonlaser

Hello there leonlaser 👋

Thank you for opening your very first issue in this project.

We will try to get back to you as soon as we can.👀

github-actions[bot] avatar Dec 29 '23 16:12 github-actions[bot]

@leonlaser Hello, I would like to confirm the issue is causing by unused imports and parameters in hbs.

We published new version v6.2.0 which refactor hbs, you can give a shot.

jackey8616 avatar Apr 05 '24 14:04 jackey8616