Łukasz Samson

Another thing to consider is if we would like to support only entire file locking (via BSD flock) or support range locking (via POSIX lockf or fcntl). I guess open...

> Should the unlock flag be its own function instead (`file:unlock/2`)? Then maybe `file:unlock/1`. On unix it would be trivial to implement with `flock` syscall. The windows implementation would need...

> It is too bad that there is no asynchronous API that we can use Windows API can be called asynchronously with IO completion ports. On unix fcntl has some...

Nice. We need to look into some details to make the API consistent 1. On unix subsequent calls to flock succeed even if file is already locked. I'm not sure...

I'm tot convinced that this is the right way to go. Obviously we cannot expect the code to deal with every possible incorrect/incomplete AST but silently ignoring it is also...

Thanks for detailed answer @scohen. You are probably right. I tend to look at the problem from my perspective. Even when not working on elixir-ls when I look for bugs...

@oo6 please look into failing tests

@oo6 Can you resolve merge conflicts?

Thanks

@DaniruKun can you resolve conflicts