ngx-gallery
ngx-gallery copied to clipboard
lukasz-galka
Angular 9 support
This pull request removes old Renderer references which are no longer supported by Angular 9.
Until that I would recommend to Use Andrey Kolkov library is fully compatible with ngx-gallery and works with Angular 9.
On Mon, 24 Feb 2020, 09:10 Fahd Allebdi, [email protected] wrote:
Can't waiting to merge these changes into master. Thank you @nOstap https://github.com/nOstap
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lukasz-galka/ngx-gallery/pull/304?email_source=notifications&email_token=AFROA2DEUEMSO6EESKPVDXTREOFGTA5CNFSM4KTAR4L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMXCETA#issuecomment-590225996, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFROA2FHELV6QCWV747QA33REOFGTANCNFSM4KTAR4LQ .
Until that I would recommend to Use Andrey Kolkov library is fully compatible with ngx-gallery and works with Angular 9.
On Thu, 19 Mar 2020, 18:24 Eloy Roura, [email protected] wrote:
Would be great to have this merged :)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lukasz-galka/ngx-gallery/pull/304#issuecomment-601340806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFROA2A7RAPLFPQEFRME3M3RIJPMDANCNFSM4KTAR4LQ .
@lukasz-galka can you merge this PR which will resolve render error. This will help us to migrate our application to angular 9
For anyone who waits for this to be merged, I would recommend to Use Andrey Kolkov library is fully compatible with ngx-gallery and works with Angular 9. https://github.com/kolkov/ngx-gallery
This seems like a great component and great effort from the owner and contributors. Github is great and I love it when developers can contribute. HOWEVER, it is kind of disheartening when owners cannot anymore follow up on contributions and get the time to merge. What can you do... life... :) Mostly I noticed this is because the owners will get busy with their work/life. Happened to me too. But yes it would be great for this to be merged. :)
