html5sortable
html5sortable copied to clipboard
lukasoppermann
[WIP] Update rollup-plugin-typescript to rollup-plugin-typescript2
Coverage increased (+1.3%) to 78.082% when pulling e9373d2b7a41d7b58dc2a00f0fc8419c62e162b3 on update-typescript-plugin into 97e33f2942023f8249d07889a8855997b885f931 on master.
Will fix #560
Can you add this to commit log and also rebase b/c the latest master branch updated a bunch of other dependencies.
Otherwise LGTM so not sure why the subject says "WIP".
Ok, have done the changes. I included WIP in the title because there are a lot of other error down the line. I removed the IE fix but I cannot check if it is used because IE11 is still not working ( #445 ). The problems are typescript errors, every usage of options is using the configuration type but it also has other types.
https://github.com/lukasoppermann/html5sortable/blob/a19d77834cf63eccb8d1fba12b6cb27f6be1d464/src/html5sortable.ts#L230-L237
So I could add a <configuration> before every usage of options but I don't think this is the best solution. I haven't found out when the object string or undefined type on options is used, so we could maybe remove them and write:
options: configuration
All the errors look like this:
semantic error TS2339: Property 'items' does not exist on type 'string | void | configuration | HTMLElement'.
Property 'items' does not exist on type 'string'.
Hey @kaffarell please verify what I am saying, but I think you could cast options to
Otherwise we would probably need to add a function that deals with the options parameter and returns a configuration, but try the above mentioned first please.
