html5sortable icon indicating copy to clipboard operation
html5sortable copied to clipboard

Published 20 hours ago • verified publisher icon lukasoppermann

Update to jest@26 leads to 4 tests failing.

Open lukasoppermann opened this issue 4 years ago • 5 comments

When updating the dependencies to jest@26 and ts-jest@26 4 tests in the __tests__/events/events.test.ts test file fail.

@kaffarell if you have time to look into this, it would be great. It is weird, but probably has to due with some change from jest.

lukasoppermann avatar Jul 04 '20 20:07 lukasoppermann

Sorry, I was not able to fix this. What I have found out:

  • That the dataTransferObject now has a type (format) as first parameter
  • That we maybe have to add a type to the created customEvent (CustomEvent & {dataTransfer?: any})

But sadly none of these things have solved the issue 😭

kaffarell avatar Jul 08 '20 19:07 kaffarell

Hey @kaffarell thank you for looking into it! I guess we just have to keep trying to figure it out. Let's skip jest@26 for now and release without it.

lukasoppermann avatar Jul 08 '20 19:07 lukasoppermann

@atodorov do you think we should start a branch with to upgrade ts-jest & jest to @26? It will need quite some fixes though.

lukasoppermann avatar Nov 18 '20 12:11 lukasoppermann

A branch + a draft PR seem like a good first step, IDK what is breaking ATM and how much work that would be to adjust the tests.

atodorov avatar Nov 18 '20 13:11 atodorov

Somehow it is mainly TS errors. Some tested parts return false instead of true now which is weird. Do you want to create a draft PR for this?

lukasoppermann avatar Nov 18 '20 13:11 lukasoppermann