Lukas Oppermann

Results 314 comments of Lukas Oppermann

> We have a major release coming up. Instead of adding a new token component, we could just modify the existing one. yes, that's the plan. I just want to...

> I've noticed that in dark mode the contrast isn't enough for background in some instances. Just updated the colors to the latest version: ![Screenshot of tokens in dark mode](https://github.com/primer/react/assets/813754/6e928cef-d66a-447d-a241-a1a98a0879f6)...

This should be changed in the new banner implementation.

I'd love for @keithamus to approve this as he is working on it. Fine from primer FR side

This repo does not currently have typescript typings and will probably not get them soon. This is not an astro issue, but rather a typescript one I think.

@clmnin I think the main issue is that this is not typed: https://github.com/lukasoppermann/html5sortable/blob/master/src/html5sortable.ts 97% is only because of the `.ts` ending. However this does not mean that all those files...

@PavelLaptev this is what I currently do. I just add custom- before the type, so custom-grid. I just figured it would be great if there was a way that was...

Hey, I did see this, but this is horribly cumbersome for hand-defined tokens. This makes a lot of sense for tools an I am using it for my figma plugin....

I would also need this for template files, which are not required in any script but will be cached so need to be refreshed.

I'd love to but I have no idea where to start. Can you point me to the file in the code where this would be added? An maybe the point...