backbone-super icon indicating copy to clipboard operation
backbone-super copied to clipboard

Make fnTest not match _super in line comments

Open JelteF opened this issue 9 years ago • 2 comments

Multiline comments are much harder to distinguish with a regex. This is probably an indication that the current method of testing wether super is used in a method is not very good. Maybe another method needs to be found.

JelteF avatar Jan 17 '16 20:01 JelteF

Can you add tests for this?

philfreo avatar Jan 18 '16 00:01 philfreo

I'm not sure how testing works in javascript, but it should not match against strings like these:

blabla \\ this is _super
\\ _super

And it should match against

this._super \\ _super

JelteF avatar Jan 18 '16 00:01 JelteF