backbone-super icon indicating copy to clipboard operation
backbone-super copied to clipboard

Remove delete

Open michaelBenin opened this issue 10 years ago • 5 comments

https://github.com/lukasolson/backbone-super/blob/master/backbone-super/backbone-super.js#L57

Delete is a major perf hit:

http://kendsnyder.com/chrome-v8-creators-with-and-delete-are-dog-slow/

michaelBenin avatar Feb 02 '15 22:02 michaelBenin

What do you suggest instead?

philfreo avatar Feb 02 '15 22:02 philfreo

So before I found this project I was using:

https://coderwall.com/p/xj81ua/a-better-way-of-extending-backbone-models-and-views

And fixed it in my hobby project:

https://github.com/michaelBenin/node-startup/blob/master/shared/utils/util.js#L5

If this was added would be a major version bump.

michaelBenin avatar Feb 03 '15 22:02 michaelBenin

@michaelBenin Can you provide a benchmark that it's really affect us in this particular case?

apsavin avatar Feb 04 '15 05:02 apsavin

@apsavin yes a perf comparison on the pr that removes the delete would be useful.

michaelBenin avatar Feb 04 '15 16:02 michaelBenin

@lukasolson when you get a chance maybe you could weigh in here.

michaelBenin avatar Feb 04 '15 16:02 michaelBenin