spring-boot-actuator-logview icon indicating copy to clipboard operation
spring-boot-actuator-logview copied to clipboard

Use stream api instead of while loop to read tail of file

Open lukashinsch opened this issue 9 years ago • 9 comments

lukashinsch avatar Mar 29 '15 11:03 lukashinsch

Coverage Status

Coverage decreased (-1.1%) to 96.61% when pulling a07dd872b4f23da91509f15ccbc5b7b9af44462d on refactor-to-streams into d693556c4dc3490a3c09080f43d2816f2bf4d927 on master.

coveralls avatar Mar 29 '15 11:03 coveralls

Coverage Status

Coverage decreased (-68.83%) to 28.89% when pulling f419d5ec75cef7eed6f9e298db4f6959ef100c64 on refactor-to-streams into d693556c4dc3490a3c09080f43d2816f2bf4d927 on master.

coveralls avatar Mar 29 '15 15:03 coveralls

Coverage Status

Coverage decreased (-68.83%) to 28.89% when pulling 66b5f50dbcaf4c10af3a542464819903e9c67640 on refactor-to-streams into d693556c4dc3490a3c09080f43d2816f2bf4d927 on master.

coveralls avatar Mar 29 '15 15:03 coveralls

Coverage Status

Coverage decreased (-79.86%) to 17.86% when pulling b79f2a52a7d2f660690a9cbb19ad539c1ec06da9 on refactor-to-streams into d693556c4dc3490a3c09080f43d2816f2bf4d927 on master.

coveralls avatar Mar 29 '15 15:03 coveralls

Coverage Status

Coverage decreased (-79.86%) to 17.86% when pulling 5ef16f5121a0f1fd7f551546b240954afb7fa5b1 on refactor-to-streams into d693556c4dc3490a3c09080f43d2816f2bf4d927 on master.

coveralls avatar Mar 29 '15 15:03 coveralls

Hi, what about this PR? Would like to see it in your master and in next release...

jgoldhammer avatar Apr 12 '16 05:04 jgoldhammer

@lukashinsch Hi, what about this PR? Would like to see it in your master and in next release...

jgoldhammer avatar Apr 12 '16 08:04 jgoldhammer

I need to check why I stopped working on this, probably needs some more work. I'll look into it as soon as I get a chance.

lukashinsch avatar Apr 12 '16 14:04 lukashinsch

Since this is an internal refactoring I released 0.2.9 without the changes

lukashinsch avatar Apr 12 '16 21:04 lukashinsch