flutter_contacts icon indicating copy to clipboard operation
flutter_contacts copied to clipboard
verified publisher icon lukasgit

Remove unused dart:async import

Open MichaelRFairhurst opened this issue 5 years ago • 5 comments

This is unused from Dart 2.1 and on when dart:core exports Future/Stream

MichaelRFairhurst avatar Sep 23 '20 20:09 MichaelRFairhurst

ping @lukasgit

MichaelRFairhurst avatar Sep 26 '20 04:09 MichaelRFairhurst

Ping once more @lukasgit :)

MichaelRFairhurst avatar Oct 01 '20 18:10 MichaelRFairhurst

I'm sorry for the delay. I lost two very special people in my life. One a couple of months ago, the other two days ago. I'm back and will work on your PR over the weekend. Thanks for your patience and understanding.

lukasgit avatar Oct 01 '20 22:10 lukasgit

Wow, that sounds horrible Lukas. :(

I will happily and patiently wait, if you do find time over this weekend I'll be super grateful, and if you don't for any reason, I will be 100% understanding. Wish you the best in the grief process, and that's more important than this PR.

MichaelRFairhurst avatar Oct 02 '20 20:10 MichaelRFairhurst

Hi. I am pleased to review your code. I think there is a lot of format change in your PR. You can make a separate PR to format the code. Let's keep this PR responsible for what you mentioned in the title (Remove unused dart:async import).

It makes PRs clear to follow up. BTW I think we don't have any formatting rule in this repo.

imaNNeo avatar Nov 11 '20 22:11 imaNNeo