flutter_contacts icon indicating copy to clipboard operation
flutter_contacts copied to clipboard

Added Notes to Contact Model & Fix issue with Android Get Contacts by Query

Open theblissprogrammer opened this issue 5 years ago • 3 comments

In order for notes to work for iOS the app needs to have it enabled by following https://developer.apple.com/documentation/bundleresources/entitlements/com_apple_developer_contacts_notes.

theblissprogrammer avatar Aug 28 '20 22:08 theblissprogrammer

I'm sorry for the delay. I lost two very special people in my life. One a couple of months ago, the other two days ago. I'm back and will work on your PR over the weekend. Thanks for your patience and understanding.

lukasgit avatar Oct 01 '20 22:10 lukasgit

Hi there. I am pleased to review your code. We should do one thing in our PRs. Because it is easy to review and easy to debug later (in case of any problem). Then I ask you to split up your PR into two PRs: 1 -> Added Notes to Contact Model 2 -> Fix issue with Android Get Contacts by Query

For the second part, please add an explanation about the problem. For sure it is great to have an issue to mention it (if doesn't exist you can create one).

Thanks!

imaNNeo avatar Nov 13 '20 05:11 imaNNeo

This is a super-useful PR. Could we merge this please?

linjonathan2001 avatar Dec 10 '20 16:12 linjonathan2001