Lukas Bach

Results 118 comments of Lukas Bach
trafficstars

> When trying to implement the way its done in the uncontrolled tree environment, I'm running into the issue of items not being iterable in the initial for loop? What...

Ah okay. One example is the [actual implementation of the uncontrolled tree](https://github.com/lukasbach/react-complex-tree/blob/main/packages/core/src/uncontrolledEnvironment/UncontrolledTreeEnvironment.tsx#L116), but I have to admit, that it is far from simple. Unfortunately, it has a lot of corner...

The icon is not explicitly defined by RTC, instead, the `dataTransfer.dropEffect` attribute is set when the user starts dragging, and is set to "move": https://github.com/lukasbach/react-complex-tree/blob/main/packages/core/src/interactionMode/ClickItemToExpandInteractionManager.ts#L56 The cursor that is shown...

I'm not sure there is unwanted behavior here. Shift-clicking an item should always override the selection with all items between the focused item, and the shift-clicked item, which will then...

As we've discussed, it is intended that control-clicking always expands the selection starting from the previously focused item. If the selection is changed from outside, and future control-click selections should...

What exactly would be the behavior that you are looking for? If the last tree is expanded, the bottom-most drag-position can only have one implementation. If we don't have it...

I agree, but if the user drags at the bottom-most location, it can only target one possible target. The Figma example looks like a great solution, but also seems to...

Hm yes that should be possible, there actually already is logic to catch drop events at the bottom of the tree, they are just interpreted as dropping on the bottom...

@tonyketcham can you elaborate a bit on the prop you propose, I'm not sure I understand what you suggest it should do.

This has in the meantime been fixed as of v2.4.0. RCT now listens to the x-coordinate of the mouse to drop items on customizable depths, allowing users to drop in...