Lukáš Vlček
Lukáš Vlček
Before merging the [`opensearch.plugin` part of the documentation](https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#opensearchpluginzip) will need some update as well.
BTW: Looking at https://github.com/opensearch-project/project-website/pull/930 it seems an article about zip POMs is in preparation 👍 What I see is that all the core plugins are expected to have `org.opensearch.plugin` groupId...
I also tested this on the **analysis-icu** plugin: I added the following line: ``` apply plugin: 'opensearch.pluginzip' ``` below this section in its build.gradle file https://github.com/opensearch-project/OpenSearch/blob/006c832c5fe8f509aa6285de90f2c7583b3dff35/plugins/analysis-icu/build.gradle#L31-L32 and run `../../gradlew --info...
Hi @prudhvigodithi If the `project.group` value is not found then the build will fail (see relevant test that I created for this case https://github.com/opensearch-project/OpenSearch/pull/4156/files#diff-ecd94c54475d67ab08078a5cdb6e381c01094427bad63b70c4e67c7978b3d895R58-R70) in which case I think the...
@prudhvigodithi I need to look at it but my initial (naive) question would be why there needs to be a code that actually live under different group than it wants...
@dblock @prudhvigodithi Thanks for the review. I was out last week. I am getting back to this now.
Oops, some precommit check are failing, I forgot to run the formatting check before the commit ... my bad. Fixing it now.
Hi @prudhvigodithi I updated the PR. It is now possible to override (customize) the `groupId` value directly in the Maven publication object. This will override whatever the actual value of...
These check failures seem to be unrelated.
Hi @prudhvigodithi If I understand correctly what you mean then I would have the same objection as @rursprung. The whole point of this PR is to enable external plugins to...