Lukas Himsel

Results 47 comments of Lukas Himsel

Please run the JS unit tests locally to validate @armantorkzaban

Hi @tobrun, we are currently working on a separate library that offers equality functions for the more complex data types of geojson. https://github.com/dartclub/turf_equality The lib is based on: https://www.npmjs.com/package/geojson-equality We...

–> DECISION: What should be done with `booleanEqual`?

Right now, the coordinate types `Position(lng, lat, alt)` and `BBox` have a `toSigned` method to do the normalization. _But_ you have to explicitly call it. Nowhere in the library is...

I found some older discussions, where this is mentioned: https://github.com/dartclub/turf_dart/pull/4#issuecomment-723502151

100% agree Maybe this could be done in the constructors of the coordinate types. Similarly to this approach maybe: https://github.com/flutter-mapbox-gl/maps/blob/01a038d93560bebcf2170dabf32e44b3cdffafcc/mapbox_gl_platform_interface/lib/src/location.dart#L16

> There is probably a small use case to be argued for allowing non-normalized coordinates, particularly with abstract geo-manipulation, but I would posit that is the exception, not the rule....

The decision was, to **keep** `Position` unsigned by default, but it can be converted to a signed coordinate easily! The imagined behaviour with signed/unsigned is similar to `DateTime`, which can...

This library is work in progress. Feel free to make a pull request, since it is not yet implemented.