Luka Peschke

Results 21 comments of Luka Peschke

@armgabrielyan No, that's currently not possible, but feel free to open a different issue if you'd like support for that :slightly_smiling_face:

@noctuid unfortunately, the percentage edge case would require some work in calamine to properly support the excel Percent type, as it is not supported there for now: https://github.com/tafia/calamine/blob/master/src/datatype.rs#L23-L44 . Are...

@noctuid Right now, dates will be coerced to strings only if the dtype of the column is explicitly set to `string`. Implicit coercion will fail, as we did not want...

With #245 mixed dtypes and string columns are now automatically coerced to strings. Since this can be unexpected behaviour for some users, there will be an option to completely disable...

Some work is still required in calamine: https://github.com/tafia/calamine/pull/409

Okay well just noticed that the API changed so we actually need to use [`workshet_range_ref`](https://docs.rs/calamine/latest/calamine/struct.Xlsx.html#method.worksheet_range_ref) in case `Sheets` are the `Xlsx` variant

# new data ## `main` ```python import argparse from time import sleep import fastexcel def get_args() -> argparse.Namespace: parser = argparse.ArgumentParser() parser.add_argument("file") parser.add_argument("-c", "--column", type=str, nargs="+", help="the columns to use")...

Good news, looks like we should be able to have lazy-by-ref once a new calamine version is out :partying_face: Benchmarks with the latest version: |iterations|owned|by ref| |---|---|---| |1|![lazy](https://github.com/ToucanToco/fastexcel/assets/17085536/b8549706-b804-4543-bb22-b8e96e66ff45)|![eager](https://github.com/ToucanToco/fastexcel/assets/17085536/9ed5a6b2-63ba-4814-bdac-a5c66cad482d)| |20|![lazy_20](https://github.com/ToucanToco/fastexcel/assets/17085536/e2c2db38-5fd3-4e1e-b336-ac62b3fe5b0b)|![eager_20](https://github.com/ToucanToco/fastexcel/assets/17085536/43d1d863-aeb2-422d-a703-d3b2aca8ea93)|

calamine 0.25.0 should be released soon, meaning I should finally be able to finish this :slightly_smiling_face: https://github.com/tafia/calamine/issues/435

### latest measurements with this branch | iterations | master | this branch (lazy) | this branch (eager) | |---|---|---|---| |1|![master_1](https://github.com/ToucanToco/fastexcel/assets/17085536/5704a112-5150-4226-be75-b2e117cf377a) |![lazy_1](https://github.com/ToucanToco/fastexcel/assets/17085536/727c3899-36b7-4529-b8b9-31255af3323c)|![eager_1](https://github.com/ToucanToco/fastexcel/assets/17085536/2debe470-6090-4324-bda2-0bfdccce76cf)| |20|![master_20](https://github.com/ToucanToco/fastexcel/assets/17085536/086b884b-1439-4a33-b461-1185d5e657e5)|![lazy_20](https://github.com/ToucanToco/fastexcel/assets/17085536/1e60a209-34e3-47e2-9998-26b690b03876) |![eager_20](https://github.com/ToucanToco/fastexcel/assets/17085536/f80edf06-e225-4675-8c4b-98a3308d3d94)