Title bar title is difficult to see when using a dark theme

[markmals]

This may be fixed in Mojave and irrelevant soon, but on High Sierra, if you use a dark theme and the "modern title bar" option, the title of the window/document is very difficult (or impossible) to see.

[lukakerr]

I'm running Mojave beta currently and don't have this issue. I suspect it's due to my logic in the MarkdownView updateUI function:

https://github.com/lukakerr/twig/blob/4429da189a56e499408766d0d36d0bd15bf2ff82/Twig/Views/MarkdownView.swift#L17-L56

I don't have another machine running a non-beta macOS version currently, so this may be hard to fix until I do

[markmals]

If you're not planning on supporting High Sierra at launch, then I wouldn't worry about it. If you are, then I can take a look and see if I can figure out what's causing it.

[lukakerr]

I do plan on supporting Sierra and High Sierra, so I’ll definitely try to fix it. I should be able to get my hands on another laptop though, but if you’re keen to take a look that would be great

[markmals]

I was going to try to fix it, but I can't figure my way around a linker bug in cmark-gfm-swift that prevents the project from building:

Ld /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Products/Debug/cmark-gfm-swift/cmark_gfm_swift.framework/Versions/A/cmark_gfm_swift normal x86_64 (in target: cmark-gfm-swift)
    cd /Users/orion/Documents/Design\ &\ Dev/Repos/twig/Pods
    export MACOSX_DEPLOYMENT_TARGET=10.12
    /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch x86_64 -dynamiclib -isysroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -L/Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Products/Debug/cmark-gfm-swift -F/Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Products/Debug/cmark-gfm-swift -filelist /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/cmark_gfm_swift.LinkFileList -install_name @rpath/cmark_gfm_swift.framework/Versions/A/cmark_gfm_swift -Xlinker -rpath -Xlinker @executable_path/../Frameworks -Xlinker -rpath -Xlinker @loader_path/Frameworks -mmacosx-version-min=10.12 -Xlinker -object_path_lto -Xlinker /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/cmark_gfm_swift_lto.o -Xlinker -export_dynamic -Xlinker -no_deduplicate -fobjc-arc -fobjc-link-runtime -L/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/macosx -Xlinker -add_ast_path -Xlinker /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/cmark_gfm_swift.swiftmodule -framework Cocoa -compatibility_version 1 -current_version 1 -Xlinker -dependency_info -Xlinker /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/cmark_gfm_swift_dependency_info.dat -o /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Products/Debug/cmark-gfm-swift/cmark_gfm_swift.framework/Versions/A/cmark_gfm_swift

duplicate symbol _cmark_render_code_point in:
    /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/render 2.o
    /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/render.o
duplicate symbol _cmark_render in:
    /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/render 2.o
    /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/render.o
duplicate symbol _cmark_render_ascii in:
    /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/render 2.o
    /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/render.o
duplicate symbol _cmark_render_xml_with_mem in:
    /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/xml 2.o
    /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/xml.o
duplicate symbol _cmark_render_xml in:
    /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/xml 2.o
    /Users/orion/Library/Developer/Xcode/DerivedData/Twig-czrdmwcuyzfjeselfmztkjviadql/Build/Intermediates.noindex/Pods.build/Debug/cmark-gfm-swift.build/Objects-normal/x86_64/xml.o
ld: 5 duplicate symbols for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[lukakerr]

Hmm I haven't seen an error like that before. Try and see if any of the answers here help: https://stackoverflow.com/questions/24298144/duplicate-symbols-for-architecture-x86-64-under-xcode