luk400
tmux3.3 upgrade -- inline plotting
I'm on (iterm2) tmux3.3 not 3.2a, so this is for folks that want to help get this amazing plugin up to speed with the new tmux version.
The Issue: inline image is displayed in the editor window instead of the output (or history) windows:
The Culprit: tmux panes.
The current and target panes are specified on the line:
vim-jukit/autoload/jukit/splits.vim +227
\. 'plt.show.__annotations__["tmux_panes"] = ["'
\. current_pane . '", "' . target_pane . '"];'
And as you can see from the variable at runtime the current_pane is getting fumbled:
╭───────── In ─────────•••
│ plt.show.__annotations__
╰──────────────────────•••
Out[9]: {'tmux_panes': ['', '%60'], 'save_dpi': 150}
The Question: Even after specifying the correct current_pane at runtime like:
plt.show.__annotations__['tmux_panes']=['%59','%60']
It still doesn't move the plot to the output split, but rather continues displaying in the editor.
An Idea: Once we answer the question above, perhaps we should name the output and history panes for more stable references like:
select-pane -T <pane_name>
Just a thought, but curious to know what others think.
After reading #14 I just realized I may have gotten around the needing to downgrade tmux thing by:
- pip install imgcat
- adding
set-option -g allow-passthrough onto my .tmux.conf (as mentioned in the imgcat README).
Still getting the plot showing up in the current_pane as opposed to target_pane, as mentioned in #14, but I think that can be fixed by:
- getting current_pane to actually set
- figure out why the
panesargument is coming up none invim-jukit/helpers/imgcat/imgcat.pyby figuring out what calls it.
Looked into this a bit more and I'm pretty sure the check that's failing is:
helpers/imgcat/imgcat.py +232
if panes is not None and is_tmux:
os.system(f'tmux select-pane -t {panes[1]}')
I tried setting a breakpoint in here as a way to start editing the codebase, but my code changes didn't appear to have any behavioral effects. Is there something I need to do to trigger a rebuild? Basically, what's your dev-workflow look like?
